rdamazio added inline comments. INLINE COMMENTS
> martinvonz wrote in test-narrow.t:457 > > This obsolete commit is completely lost afterwards, which kind of violates > > the principle of "all changes are kept forever" - should it dump this > > somewhere for safekeeping? > > Yes, it does dump it to a backup bundle (see output on line 474). > > > Also, what if you just don't get rid of the files, and simply remove it > > from the narrowspec? It'll stop processing/pulling/pushing the directory, > > but no data is lost. > > That's just about the working directory, right? This file is unchanged in the > working directory at the time of `hg tracked --auto-remove-includes`... > That's just about the working directory, right? This file is unchanged in the > working directory at the time of hg tracked --auto-remove-includes... No, I meant what if you don't get rid of the .i files. But you raise a good point - shouldn't you also clean up the working directory? Alternatively, or in addition, maybe a confirmation prompt pointing out which commits and narrowspec entries will be dropped may be useful. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6848/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6848 To: martinvonz, durin42, #hg-reviewers Cc: rdamazio, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel