martinvonz added inline comments. INLINE COMMENTS
> martinvonz wrote in test-narrow.t:457 > > No, I meant what if you don't get rid of the .i files. > > This is not changing which .i files we get rid of; the behavior should be the > same as if you had typed `hg tracked --removeinclude path:d0 --removeinclude > path:d2`. > > > But you raise a good point - shouldn't you also clean up the working > > directory? > > Yes, it should be, but it doesn't print those files if they were clean. I've > added a call to `hg files` to the test so you can see that they are cleaned > up. > > > Alternatively, or in addition, maybe a confirmation prompt pointing out > > which commits and > > narrowspec entries will be dropped may be useful. > > I considered that but I wasn't sure if it would be more annoying than > helpful. Want me to add that? I added that prompt. We also talked about adding a `--dry-run` option instead of the prompt, but that seemed harder because it would need to be handled in many different cases, including `--update-working-copy`, even if we just decide to error out. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6848/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6848 To: martinvonz, durin42, #hg-reviewers Cc: rdamazio, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
