yuja added a comment.

  > +    cl.__class__ = type('filteredchangelog',
  > +                        (filteredchangelogmixin, cl.__class__),
  > +                        {})
  
  Nit: maybe this can be just `class filteredchangelog(...): pass` since
  we don't name the type dynamically.
  
  And we might need a class cache like _filteredrepotypes to work around
  leaks of dynamically-created types.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7256/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7256

To: martinvonz, #hg-reviewers, indygreg
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to