martinvonz added a comment.
In D7256#107172 <https://phab.mercurial-scm.org/D7256#107172>, @yuja wrote: >> + cl.__class__ = type('filteredchangelog', >> + (filteredchangelogmixin, cl.__class__), >> + {}) > > Nit: maybe this can be just `class filteredchangelog(...): pass` since > we don't name the type dynamically. Done in https://www.mercurial-scm.org/repo/hg/rev/85628a595c37. > And we might need a class cache like _filteredrepotypes to work around > leaks of dynamically-created types. It seems like there's some caching in `_clcache` already. Maybe that's enough? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7256/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7256 To: martinvonz, #hg-reviewers, indygreg Cc: yuja, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
