marmoute added inline comments. INLINE COMMENTS
> martinvonz wrote in nodemap.py:47-49 > Unless the Python code is going to mmap the file contents directly into > Python objects (which I don't think is going to happen), there will be > serialization and deserialization involved. The Python code is not meant to be use in production, especially not the parsing one (because it bring no advantage). So I want the API to be named after the actual semantic, not after this annecdotical python code. > martinvonz wrote in nodemap.py:85 > I don't see why you'd be against `enumerate()` here. Are you simply against > `enumerate()` in general? I am not against enumerate in general, I just feel like direct indexing is clearer here (and the different is not that important here anyway). REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7834/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7834 To: marmoute, #hg-reviewers, martinvonz Cc: martinvonz, mjpieters, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
