marmoute added inline comments.

INLINE COMMENTS

> marmoute wrote in nodemap.py:85
> I am not against enumerate in general, I just feel like direct indexing is 
> clearer here (and the different is not that important here anyway).

Also, using `enumerate` in the incremental version of this code would make 
things sinificantly messier, so it won't. And keeping the two code similar has 
value.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7834/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7834

To: marmoute, #hg-reviewers, martinvonz
Cc: martinvonz, mjpieters, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to