This revision is now accepted and ready to land. martinvonz added a comment. martinvonz accepted this revision.
In D7922#121720 <https://phab.mercurial-scm.org/D7922#121720>, @durin42 wrote: > I think this looks good, but I want Martin to ack that his concern is adequately resolved. Yes, looks good to me now. Thanks. INLINE COMMENTS > Alphare wrote in matchers.rs:224 > I've looked into the behavior of Re2. It will return an error if the DFA runs > out of memory, which seems perfectly reasonable. > I will simplify the Rust code, however I feel like you're better suited than > I am to fix the Python side of things, since I don't really understand the > ins-and-outs of the problem. Thanks for fixing the Rust side. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7922 To: Alphare, #hg-reviewers, pulkit, martinvonz, durin42 Cc: martinvonz, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
