pulkit added a comment.
In D7922#123193 <https://phab.mercurial-scm.org/D7922#123193>, @martinvonz wrote: > In D7922#123057 <https://phab.mercurial-scm.org/D7922#123057>, @pulkit wrote: > >> @martinvonz this (and next few patches) seems accepted by you and Augie. Should I go ahead and push it or I missed some discussion on IRC about it? > > You can push it. I wanted to finish the cleanup to the regex grouping that I mentioned earlier, but that can be done separately. But that's the only reason I haven't queued this patch anyway. You mean cleanup on the Python side or on the rust side? IIUC, the rust side is fine now. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7922 To: Alphare, #hg-reviewers, pulkit, martinvonz, durin42 Cc: martinvonz, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
