On 11/24/2011 12:35 PM, Eric Anholt wrote:
On Wed, 23 Nov 2011 15:08:23 -0800, Ian Romanick<i...@freedesktop.org>  wrote:
On 11/23/2011 02:35 PM, Brian Paul wrote:
If alpha test is enabled and there's no color buffers we still need the
fragment shader to emit a color.

Fixes piglit fbo-alphatest-nocolor-ff failures with Gallium drivers.

It looks like this an Eric's recent patch
(http://lists.freedesktop.org/archives/mesa-dev/2011-November/015049.html)
may trip over each other.  You guys should sort this out.

Nope, this should fix the other piglit test related to alpha test with
no color.

The patch looks good, except that the _NEW_COLOR state flag in use here
is new, and would need to be added to prog_flags in state.c.

New patch posted.

BTW, when I tried the fbo-alphatest-nocolor tests on my i965 the tests are skipped, apparently because of an incomplte FBO.

-Brian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to