> On May 2, 2017, at 5:33 PM, Marek Olšák <mar...@gmail.com> wrote: > > On Wed, May 3, 2017 at 12:18 AM, Cherniak, Bruce > <bruce.chern...@intel.com> wrote: >> >> On May 2, 2017, at 4:11 PM, Cherniak, Bruce <bruce.chern...@intel.com> >> wrote: >> >> >> On May 2, 2017, at 3:41 PM, Cherniak, Bruce <bruce.chern...@intel.com> >> wrote: >> >> PART 2: Call for testing >> >> These drivers have been tested: >> - ddebug >> - llvmpipe >> - r300 (also with SWTCL) >> - r600 >> - radeonsi >> - softpipe >> - trace >> >> These drivers need testing: >> - etnaviv >> - freedreno >> - nv30 >> - nv50 >> - nvc0 >> - svga >> - swr >> - vc4 >> - virgl >> >> >> Tested on swr. No piglit regressions. >> >> >> Alt-fact, I spoke too soon. Seeing a couple of crashes in >> gl-2.0-vertexattribpointer tests. Tracking down now. >> >> >> All clear. >> >> Using your repo with branch “gallium-cleanup” I was seeing some crashes that >> we had fixed some time back. >> Not sure what’s going on there. But, our proxy doesn’t pass “git” protocol, >> so I had a hard time pulling that >> repo. Could very well have created a “franken-mess”(tm). >> >> Using what patchwork calls your “rev 1” series applied to tip, all works >> fine. >> (What it calls “rev 2” isn’t really viable.)
I found my confusion. I compared results from gallium-cleanup versus master. We made some fixes that are in master, but not yet in your gallium-cleanup branch. One thing that concerns me is the change you needed to make to swr_draw.cpp swr_update_derived(). /* Set vertex & index buffers */ /* (using draw info if called by swr_draw_vbo) */ - if (ctx->dirty & SWR_NEW_VERTEX) { + /* TODO: This is always true, because the index buffer comes from + * pipe_draw_info. + */ + if (1 || ctx->dirty & SWR_NEW_VERTEX) { This is going to cause revalidation of vertex/index buffers every draw & clear, even for the case of vbo and non-indexed draws. I can see this affecting performance. Not something we expect you to address in this patch, however. We’ll get around to it. Thanks, Bruce _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev