On Thu, 22 Dec 2011 17:43:57 -0800, "Ian Romanick" <i...@freedesktop.org> wrote:
> From: Ian Romanick <ian.d.roman...@intel.com>
> 
> There are a couple scenarios where the source could be zero and the
> operand could be either SRC_ALPHA or ONE_MINUS_SRC_ALPHA.  For
> example, if the source was ZERO.  This would result in something like
> (0).w, and a later call to ir_validate would get angry.
> 
> Signed-off-by: Ian Romanick <ian.d.roman...@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42517

In other cases of handling this in the code, I was using the little
smear() helper function.  I'd tend towards using that here as well, but
no strong feeling.

There's also a "bump = get_source(...)" in the bumpmap handling that
looks like it could use the same treatment.

I think I've reviewed all the other swizzles in the code now.

Attachment: pgpnTrQ24lC7r.pgp
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to