On Tue, Jan 10, 2012 at 2:40 AM, Jakob Bornecrantz <wallbra...@gmail.com> wrote: > On Tue, Jan 10, 2012 at 12:01 AM, Alan Coopersmith > <alan.coopersm...@oracle.com> wrote: >> On 01/ 9/12 02:53 PM, Jakob Bornecrantz wrote: >>> >>> - struct pipe_shader_state pss = { 0 }; >>> + struct pipe_shader_state pss; >>> + memset(&pss, 0, sizeof(pss)); >> >> >> Those do the same thing, just via a function call instead of compiler >> builtin. >> What warning is being silenced by that change? > > I don't have the build log with me right, but I think it was something > about uninitialized field near "pss.tokens = tokens;", I will take a > closer look. That struct has substruct it seems that GCC wants you to > initialize all of them.
src/gallium/drivers/rbug/rbug_core.c: In function ‘rbug_shader_create_locked’: src/gallium/drivers/rbug/rbug_core.c:107:11: warning: missing initializer [-Wmissing-field-initializers] src/gallium/drivers/rbug/rbug_core.c:107:11: warning: (near initialization for ‘pss.stream_output’) [-Wmissing-field-initializers] gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1 Cheers, Jakob. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev