Yeah, maybe. I'll do that.
On Fri, 2018-12-07 at 11:31 -0600, Jason Ekstrand wrote:
> I think it's probably less code to just make a separate 16-bit case.
>
> On Tue, Dec 4, 2018 at 1:18 AM Iago Toral Quiroga <ito...@igalia.com>
> wrote:
> > ---
> >
> > src/intel/compiler/brw_fs_nir.cpp | 27 +++++++++++++++++++++------
> >
> > 1 file changed, 21 insertions(+), 6 deletions(-)
> >
> >
> >
> > diff --git a/src/intel/compiler/brw_fs_nir.cpp
> > b/src/intel/compiler/brw_fs_nir.cpp
> >
> > index 3eba8a478f5..559b55a0f84 100644
> >
> > --- a/src/intel/compiler/brw_fs_nir.cpp
> >
> > +++ b/src/intel/compiler/brw_fs_nir.cpp
> >
> > @@ -938,14 +938,29 @@ fs_visitor::nir_emit_alu(const fs_builder
> > &bld, nir_alu_instr *instr)
> >
> > * Predicated OR ORs 1.0 (0x3f800000) with the sign bit
> > if val is not
> >
> > * zero.
> >
> > */
> >
> > - bld.CMP(bld.null_reg_f(), op[0], brw_imm_f(0.0f),
> > BRW_CONDITIONAL_NZ);
> >
> > + fs_reg zero, one_mask, sign_mask;
> >
> > + brw_reg_type reg_type;
> >
> > + if (type_sz(op[0].type) == 4) {
> >
> > + zero = brw_imm_f(0.0f);
> >
> > + one_mask = brw_imm_ud(0x3f800000);
> >
> > + sign_mask = brw_imm_ud(0x80000000);
> >
> > + reg_type = BRW_REGISTER_TYPE_UD;
> >
> > + } else {
> >
> > + assert(type_sz(op[0].type) == 2);
> >
> > + zero = retype(brw_imm_uw(0), BRW_REGISTER_TYPE_HF);
> >
> > + one_mask = brw_imm_uw(0x3c00);
> >
> > + sign_mask = brw_imm_uw(0x8000);
> >
> > + reg_type = BRW_REGISTER_TYPE_UW;
> >
> > + }
> >
> > +
> >
> > + bld.CMP(bld.null_reg_f(), op[0], zero,
> > BRW_CONDITIONAL_NZ);
> >
> >
> >
> > - fs_reg result_int = retype(result, BRW_REGISTER_TYPE_UD);
> >
> > - op[0].type = BRW_REGISTER_TYPE_UD;
> >
> > - result.type = BRW_REGISTER_TYPE_UD;
> >
> > - bld.AND(result_int, op[0], brw_imm_ud(0x80000000u));
> >
> > + fs_reg result_int = retype(result, reg_type);
> >
> > + op[0].type = reg_type;
> >
> > + result.type = reg_type;
> >
> > + bld.AND(result_int, op[0], sign_mask);
> >
> >
> >
> > - inst = bld.OR(result_int, result_int,
> > brw_imm_ud(0x3f800000u));
> >
> > + inst = bld.OR(result_int, result_int, one_mask);
> >
> > inst->predicate = BRW_PREDICATE_NORMAL;
> >
> > } else {
> >
> > /* For doubles we do the same but we need to consider:
> >
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
