Chris Forbes <chr...@ijw.co.nz> writes: > V2: - fix multiline comment style > - stop using ASSERT_OUTSIDE_BEGIN_END_AND_FLUSH since that > doesn't exist anymore. > > V3: - check for the extension being enabled > - tidier flagging of _NEW_MULTISAMPLE > - fix weird indentation in get.c
> @@ -92,7 +96,20 @@ _mesa_GetMultisamplefv(GLenum pname, GLuint index, GLfloat
> * val)
> void GLAPIENTRY
> _mesa_SampleMaski(GLuint index, GLbitfield mask)
> {
> - assert(!"Not implemented");
> - // TODO: make this work
> + GET_CURRENT_CONTEXT(ctx);
> +
> + if (!ctx->Extensions.ARB_texture_multisample) {
> + _mesa_error(ctx, GL_INVALID_OPERATION, "glSampleMaski");
> + return;
> + }
> +
> + FLUSH_VERTICES(ctx, _NEW_MULTISAMPLE);
Odd to have this between the two error checks. Perhaps do it just
before setting the samplemaskvalue?
Other than that, patches 5-8 are
Reviewed-by: Eric Anholt <e...@anholt.net>
> +
> + if (index != 0) {
> + _mesa_error(ctx, GL_INVALID_VALUE, "glSampleMaski(index)");
> + return;
> + }
> +
> + ctx->Multisample.SampleMaskValue = mask;
> }
pgpo5Pi7LPL6M.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
