On Friday, December 19, 2014 04:36:55 PM Jason Ekstrand wrote: > All we have right now are stub implementations of these that do nothing. > Let's avoid confusing apps by advertising an extension we don't actually > support. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87516 > --- > src/mesa/main/extensions.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c > index 0df04c2..d7bc28a 100644 > --- a/src/mesa/main/extensions.c > +++ b/src/mesa/main/extensions.c > @@ -118,7 +118,7 @@ static const struct extension extension_table[] = { > { "GL_ARB_fragment_shader", o(ARB_fragment_shader), > GL, 2002 }, > { "GL_ARB_framebuffer_object", > o(ARB_framebuffer_object), GL, 2005 }, > { "GL_ARB_framebuffer_sRGB", o(EXT_framebuffer_sRGB), > GL, 1998 }, > - { "GL_ARB_get_program_binary", o(dummy_true), > GL, 2010 }, > + { "GL_ARB_get_program_binary", o(dummy_false), > GL, 2010 }, > { "GL_ARB_gpu_shader5", o(ARB_gpu_shader5), > GLC, 2010 }, > { "GL_ARB_half_float_pixel", o(dummy_true), > GL, 2003 }, > { "GL_ARB_half_float_vertex", o(ARB_half_float_vertex), > GL, 2008 }, > @@ -296,7 +296,7 @@ static const struct extension extension_table[] = { > { "GL_OES_fbo_render_mipmap", o(dummy_true), > ES1 | ES2, 2005 }, > { "GL_OES_fixed_point", o(dummy_true), > ES1, 2002 }, > { "GL_OES_framebuffer_object", o(dummy_true), > ES1, 2005 }, > - { "GL_OES_get_program_binary", o(dummy_true), > ES2, 2008 }, > + { "GL_OES_get_program_binary", o(dummy_false), > ES2, 2008 }, > { "GL_OES_mapbuffer", o(dummy_true), > ES1 | ES2, 2005 }, > { "GL_OES_packed_depth_stencil", o(dummy_true), > ES1 | ES2, 2007 }, > { "GL_OES_point_size_array", o(dummy_true), > ES1, 2004 }, >
I've always thought it was stupid to advertise GL_ARB_get_program_binary. There's no benefit and it can only screw up applications. Ian wanted it enabled, if I recall. Hunk 1 is: Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> As you said, hunk 2 is probably not legal.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
