On 21/09/15 12:39, Iago Toral wrote: > Hi Kristian, > > On Fri, 2015-09-18 at 16:56 -0700, Kristian Høgsberg wrote: >> On Thu, Sep 10, 2015 at 03:35:16PM +0200, Iago Toral Quiroga wrote: >>> Hi, >>> >>> this is the latest version of the ARB_shader_storage_buffer_object >>> implementation. A good part of the frontend bits for this are already in >>> master, but this adds some more missing pieces, specifically std430 and >>> memory qualifiers. Additionally, this provides the i965 implementation. >> >> I've gone through all patches in the series and I replied to patches >> where I had comments. Overall, the series look good and with the >> comments addressed, I'm ready to give my Reviewed-by for the series. >> I want to take a closer look at the atomics lowering in patches 49+, >> but I'm done for today. Base on the quick look-through I did, I don't >> expect to find any showstoppers there. > > great, thanks for reviewing this! We will send new versions of the > patches for which you had comments or reply to your comments otherwise. >
I have pushed the series to master branch \o/ I would like to say "thank you" for all the people involved that gave us amazing reviews, comments and, last but not least, tested the patch series! Thanks :-) Sam _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev