On Thu 22 Oct 2015, Emil Velikov wrote: > On 22 October 2015 at 07:43, Erik Faye-Lund <kusmab...@gmail.com> wrote: > > On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery <nanleych...@gmail.com> > > wrote: > >> From: Nanley Chery <nanley.g.ch...@intel.com> > >> > >> Since the version numbers being compared are integral and we don't ever > >> expect gl_context::Version to be equal to 0, subtract 1 from the rhs of > >> the equation and perform the optimization of removing the equality check. > > > > Is this really an improvement? Changing '>=' to '>' and then making > > all versions off-by-one seems like trading less readable and debugable > > code for no real upside... > > Pretty much my line of thinking. Perhaps it was applicable for earlier > iterations of the series ?
That's my opinion too. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
