On Wed, Oct 21, 2015 at 11:43 PM, Erik Faye-Lund <kusmab...@gmail.com> wrote:
> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery <nanleych...@gmail.com> > wrote: > > From: Nanley Chery <nanley.g.ch...@intel.com> > > > > Since the version numbers being compared are integral and we don't ever > > expect gl_context::Version to be equal to 0, subtract 1 from the rhs of > > the equation and perform the optimization of removing the equality check. > > Is this really an improvement? Changing '>=' to '>' and then making > all versions off-by-one seems like trading less readable and debugable > code for no real upside... > After looking at the assembly generated, I've determined that this is actually not an improvement. I'll drop this patch. I was using .text size as my metric earlier. I now realize that it isn't completely reliable.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
