Adam Jackson wrote:
On Thursday 19 January 2006 13:43, Ian Romanick wrote:
Adam Jackson wrote:
Log message:
Avoid a crash when the user has enabled glVertex{,Attrib}Pointer but
hasn't filled in a valid pointer for that attribute or vertex array.
NAK. Any app that is hitting a crash because of this is wrong. It is
likely that such apps will tank on other implementations, so working
around this app bug in Mesa is a disservice to the developer.
The offender is glxcompmgr, for the record. See screen.c around line 770.
My concern with backing this out is how it affects the indirect rendering
case, if at all. I would prefer that clients not be able to crash the server
by enabling client state and then not filling it in; although it appears to
"work" in indirect mode as it is, so maybe I'm misguided.
Note that your change doesn't prevent a malicious or misguided client
from crashing itself in this way, or presumably the server if the same
problem exists there. You only check against a single invalid address
(ie. zero), but there are plenty of other illegal addresses out there
which will also generate a SEGV (starting at Ptr == 1) ...
Keith
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
