Lukas Hejtmanek wrote:
On Fri, Apr 21, 2006 at 12:22:56PM -0700, Ian Romanick wrote:
why this extension is not included in i915 driver? I added it to sources,
recompiled and tested with www.glest.org, it seems to be ok, so I think it could
be included into Mesa/src/mesa/drivers/dri/i915/i915_context.c:
The i915 driver uses (used to use?) code within the driver to convert
texture environments to fragment programs.  At the time, this code did
not support GL_ARB_texture_env_crossbar.  There is also generic code in
core Mesa for translating texture environments to fragment programs.
This code, which is used by the r300 driver, does support
GL_ARB_texture_env_crossbar.  I proposed a similar patch sometime ago,
but the patch was rejected until the i915 driver was modified to use the
generic code in Mesa.

I noticed this:
i915_vtbl.c:157
/* Don't support texture crossbar yet */
   OUT_BATCH(_3DSTATE_COORD_SET_BINDINGS |
             CSB_TCB(0, 0) |
             CSB_TCB(1, 1) |
             CSB_TCB(2, 2) |
             CSB_TCB(3, 3) |
             CSB_TCB(4, 4) |
             CSB_TCB(5, 5) |
             CSB_TCB(6, 6) |
             CSB_TCB(7, 7));


Does it mean that enabling GL_ARB_texture_env_crossbar is useless?

I'm not sure why you'd need to change the routing of texture coord sets to the texture interpolators (at least it looks to me this code does that) for texture_env_crossbar, since fragment programs can access the results of the sampled textures freely anyway, but the code in i915_texprog.c clearly doesn't handle that extension (unless I'm missing something and that code isn't used any longer). It looks to me like you could just change the get_source function to make env_crossbar working though (just use src-GL_TEXTURE0 instead of unit as param). I'm not familiar with the intel driver however, it's possible it doesn't work like that.

Roland


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to