On Mon, Feb 16, 2009 at 8:59 AM, José Fonseca <jfons...@vmware.com> wrote: > On Fri, 2009-02-13 at 06:41 -0800, Dan Nicholson wrote: >> On Fri, Feb 13, 2009 at 02:12:25PM +0000, José Fonseca wrote: >> > On Fri, 2009-02-13 at 06:05 -0800, Jakob Bornecrantz wrote: >> > > On 13 feb 2009, at 15.00, José Fonseca wrote: >> > > >> > > > On Fri, 2009-02-13 at 05:44 -0800, Maciej Cencora wrote: >> > > >> On środa, 11 lutego 2009 00:47:52 Brian Paul wrote: >> > > >>> OK, the merge is done and pushed. Seems to have gone OK. >> > > >>> >> > > >>> Please report any problems found and we'll try to fix them ASAP. >> > > >>> >> > > >>> -Brian >> > > >> >> > > >> The GLEW library isn't build so all progs/demos builds fail. One >> > > >> have to >> > > >> manually enter the src/glew directory and type make to make it build. >> > > > >> > > > Which configuration are you using? GLEW is enabled on all >> > > > configurations >> > > > for which GLUT is also enabled. >> > > >> > > Autoconf/configure completely overwrites any settings in configs/ >> > > default. >> > > >> > > Cheers Jakob. >> > >> > Maciej >> > >> > I haven't tested, but this should do the trick if you're using autoconf: >> > >> > diff --git a/configure.ac b/configure.ac >> > index a9a8d5a..a523f76 100644 >> > --- a/configure.ac >> > +++ b/configure.ac >> > @@ -474,6 +474,7 @@ yes) >> > if test "$mesa_driver" != osmesa; then >> > PROGRAM_DIRS="xdemos" >> > fi >> > + SRC_DIRS="$SRC_DIRS glew" >> > ;; >> > *) >> > # verify the requested demos directories exist >> > @@ -483,6 +484,7 @@ yes) >> > AC_MSG_ERROR([Program directory '$demo' doesn't exist]) >> > done >> > PROGRAM_DIRS="$demos" >> > + SRC_DIRS="$SRC_DIRS glew" >> > ;; >> > esac >> >> Since GLEW is only needed with the GLUT demos, wouldn't this be better? >> >> diff --git a/configure.ac b/configure.ac >> index 549ca90..36b5859 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -1006,7 +1006,7 @@ if test "x$enable_glut" = xyes && test "$mesa_driver" >> = osmesa; then >> fi >> >> if test "x$enable_glut" = xyes; then >> - SRC_DIRS="$SRC_DIRS glut/glx" >> + SRC_DIRS="$SRC_DIRS glut/glx glew" >> GLUT_CFLAGS="" >> if test "x$GCC" = xyes; then >> GLUT_CFLAGS="-fexceptions" > > Dan, > > Although only GLUT examples depend on GLEW atm, GLEW itselfg does not > depend on GLUT, and we might want to use GLEW in non GLUT examples (eg., > the GLX examples)
Yeah, after I went and looked at what glew actually was, it became apparent that this wasn't quite right. Right now, I think the right way to handle it is like glut/glu/glw. --disable-glew if you want that, then the demos that need glew will be disabled. The only thing that really stopped me from doing that is that glew isn't an installed library. So, it didn't seem to make sense to say "enable/disable this internal static library". Maybe it should just always be on right now, which is easy. See patch below. -- Dan diff --git a/configure.ac b/configure.ac index 36b5859..2d48ccf 100644 --- a/configure.ac +++ b/configure.ac @@ -409,7 +409,7 @@ esac dnl dnl Driver specific build directories dnl -SRC_DIRS="mesa egl" +SRC_DIRS="mesa egl glew" GLU_DIRS="sgi" WINDOW_SYSTEM="" GALLIUM_DIRS="auxiliary drivers state_trackers" @@ -1006,7 +1006,7 @@ if test "x$enable_glut" = xyes && test "$mesa_driver" = osmesa; then fi if test "x$enable_glut" = xyes; then - SRC_DIRS="$SRC_DIRS glut/glx glew" + SRC_DIRS="$SRC_DIRS glut/glx" GLUT_CFLAGS="" if test "x$GCC" = xyes; then GLUT_CFLAGS="-fexceptions" ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev