On Mit, 2009-03-18 at 12:46 -0700, Eric Anholt wrote:
> This requires upgrading the interface so that the argument to
> glXBindTexImageEXT isn't just dropped on the floor.  Note that this only
> fixes the accelerated path on Intel, as Mesa's texture format support is
> missing x8r8g8b8 support (right now, GL_RGB textures get uploaded as a8r8gb8,
> but in this case we're not doing the upload so we can't really work around it
> that way).
> 
> Fixes bugs with compositors trying to use shaders that use alpha channels, on
> windows without a valid alpha channel.  Bug #19910 and likely others as well.

Cool, so I'll finally be able to use compiz on the Thinkpad. :)


> @@ -231,7 +231,7 @@ struct __DRItexOffsetExtensionRec {
>  
> 
>  #define __DRI_TEX_BUFFER "DRI_TexBuffer"
> -#define __DRI_TEX_BUFFER_VERSION 1
> +#define __DRI_TEX_BUFFER_VERSION 2
>  struct __DRItexBufferExtensionRec {
>      __DRIextension base;
>  
> @@ -239,11 +239,23 @@ struct __DRItexBufferExtensionRec {
>       * Method to override base texture image with the contents of a
>       * __DRIdrawable. 
>       *
> -     * For GLX_EXT_texture_from_pixmap with AIGLX.
> +     * For GLX_EXT_texture_from_pixmap with AIGLX.  Deprecated in favor of
> +     * setTexBuffer2 in version 2 of this interface
>       */
>      void (*setTexBuffer)(__DRIcontext *pDRICtx,
>                        GLint target,
>                        __DRIdrawable *pDraw);
> +
> +    /**
> +     * Method to override base texture image with the contents of a
> +     * __DRIdrawable, including the required texture format attribute.
> +     *
> +     * For GLX_EXT_texture_from_pixmap with AIGLX.
> +     */
> +    void (*setTexBuffer2)(__DRIcontext *pDRICtx,
> +                       GLint target,
> +                       GLint format,
> +                       __DRIdrawable *pDraw);
>  };
>  
>  /**

It might be better to create a new extension though, so the broken hook
can be phased out.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to