On Thu, 2009-03-19 at 14:34 -0700, Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Eric Anholt wrote: > > This requires upgrading the interface so that the argument to > > glXBindTexImageEXT isn't just dropped on the floor. Note that this only > > fixes the accelerated path on Intel, as Mesa's texture format support is > > missing x8r8g8b8 support (right now, GL_RGB textures get uploaded as > > a8r8gb8, > > but in this case we're not doing the upload so we can't really work around > > it > > that way). > > > > Fixes bugs with compositors trying to use shaders that use alpha channels, > > on > > windows without a valid alpha channel. Bug #19910 and likely others as > > well. > > My only comment is that using 3 and 4 instead of GL_RGB and GL_RGBA in > translate_tex_format and its callers is odd. It's not enough to make me > NAK the patch, though.
I was just following what the broken code before was trying to do. I'll change that in the push. -- Eric Anholt [email protected] [email protected]
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
