> > > > This patch series focuses on core mesa. The biggest thing missing is a > > convension for drivers to enable extensions. I think some refactorings > > are needed before a convension can be established. > > I'm actually not too enthusiastic about these patches. > > When we omit a feature such as convolution, I'd rather entirely omit > convolve.c and convolve.h from the build rather than define a bunch of > new no-op convolution stub functions in convolve.h > > The current system for dealing with features might be prone to > occasional build failures, but when I did the ES subset it really > wasn't a big deal (it was easy to find the stale calls to removed > functions and fix them). The current feature system is really simple, > and results in a bit less code. > > Do you feel strongly about these patches?
does the current feature use ifdefs in the C code to avoid calling entrypoints if the feature isn't enabled? vs having null C functions in the header files? The first isn't generally a good idea as code doesn't get built when the feature is off, so people editing around the feature can forget to fix things inside the ifdefs, the second approach is a lot sounder generally. not 100% sure which way we have now vs what we are getting. Dave. > > -Brian > > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > Mesa3d-dev mailing list > Mesa3d-dev@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mesa3d-dev > > ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
