Roland, Looks good to me too.
Jose On Tue, 2009-12-08 at 08:19 -0800, Keith Whitwell wrote: > Roland, > > This looks OK to me, hopefully this will see us getting on top of strict > aliasing issues after all these years... > > Keith > > On Mon, 2009-12-07 at 18:14 -0800, Roland Scheidegger wrote: > > Hello, > > > > I'm planning to merge gallium-strict-aliasing branch soon, which will > > bring another gallium api change. > > pipe_reference function has different arguments, because the old version > > was pretty much not really useful for strict-aliasing compliant code > > (util_color_pack functions also gets an update for the same reason). > > The goal of course it to enable builds which do no longer need > > -fno-strict-aliasing. scons builds already didn't do this (which was a > > bug since the builds were indeed broken). > > I didn't check all drivers for strict-aliasing compliance, but for > > gallium everybody should make sure the code they are submitting is > > according to strict aliasing rules (*). One downside of compiling with > > -fno-strict-aliasing is also that you don't get the warnings wrt strict > > aliasing, so you might have missed that in the past. > > (There are no build system changes yet, there's still some strict > > aliasing violating code in shader/grammar which should get replaced soon > > anyway.) > > > > (*) Strictly speaking, it looks like c99 actually has undefined > > behaviour writing and reading different members of a union (wtf?), but > > this is considered acceptable here, and all compilers should support it. > > > > Roland > > > > ------------------------------------------------------------------------------ > > Return on Information: > > Google Enterprise Search pays you back > > Get the facts. > > http://p.sf.net/sfu/google-dev2dev > > _______________________________________________ > > Mesa3d-dev mailing list > > Mesa3d-dev@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mesa3d-dev > > > ------------------------------------------------------------------------------ > Return on Information: > Google Enterprise Search pays you back > Get the facts. > http://p.sf.net/sfu/google-dev2dev > _______________________________________________ > Mesa3d-dev mailing list > Mesa3d-dev@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mesa3d-dev ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
