-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Brian Paul wrote: > Ian Romanick wrote: >> >> Why is the DataType for MESA_FORMAT_Z24_S8 and related types >> GL_UNSIGNED_INT? Right now the Intel drivers manually set the >> renderbuffer DataType for these types to GL_UNSIGNED_INT_24_8 for these >> formats. > > The renderbuffer DataType and gl_format DataType are different things. > The former are related to the get/put span functions and the later > describes the format's encoding. > > Can you point to the specific code you're concerned with?
I'm looking at the handling of MESA_FORMAT_S8_Z24 in intel_create_renderbuffer. This uses has 'irb->Base.DataType = GL_UNSIGNED_INT_24_8_EXT'. There's a lot of code like this in intel_fbo.c that seems like it should be replaced with calls to format query functions supplied by format.c. My goal is to fix the last couple regressions introduced by the texformat changes and get the XRGB8888 formats working. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkse0uoACgkQX1gOwKyEAw+oMgCeO1kqW4JV6h1zXBTmtSV7zbYL v58An20xTK0/z5UUQ7dBkGR7waPjZwXx =ctS7 -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
