On Wed, 2010-01-06 at 00:50 -0800, michal wrote: > diff --git a/src/gallium/drivers/svga/svga_tgsi.h > b/src/gallium/drivers/svga/svga_tgsi.h > index 896c90a..d132525 100644 > --- a/src/gallium/drivers/svga/svga_tgsi.h > +++ b/src/gallium/drivers/svga/svga_tgsi.h > @@ -39,24 +39,24 @@ struct tgsi_token; > > struct svga_vs_compile_key > { > - ubyte need_prescale:1; > - ubyte allow_psiz:1; > unsigned zero_stride_vertex_elements; > - ubyte num_zero_stride_vertex_elements:6; > + unsigned need_prescale:1; > + unsigned allow_psiz:1; > + unsigned num_zero_stride_vertex_elements:6; > }; > > struct svga_fs_compile_key > { > - boolean light_twoside:1; > - boolean front_cw:1; > + unsigned light_twoside:1; > + unsigned front_cw:1; > ubyte num_textures; > ubyte num_unnormalized_coords; > struct { > - ubyte compare_mode : 1; > - ubyte compare_func : 3; > - ubyte unnormalized : 1; > + unsigned compare_mode : 1; > + unsigned compare_func : 3; > + unsigned unnormalized : 1; > > - ubyte width_height_idx : 7; > + unsigned width_height_idx : 7; > > ubyte texture_target; > } tex[PIPE_MAX_SAMPLERS];
Michal, these two structs should be kept as small as possible. It looks like there has been some drift away from well-packed fields anyway, but if you're making this change can you please take a moment to repack the fields as a result and get these down to as small as possible? In particular, it looks like fs_compile_key::tex array has probably doubled in size - could you repack it by changing texture_target to, eg: unsigned texture_target:8; or similar? The same would apply for the other ubyte fields that are now probably no longer tightly packed. Keith ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev