Roel Kluin wrote: > I also found several tests on unsigned variables which do > nothing. should they be removed or changed otherwise?
I think they could be removed. However, note that src/glx/x11/indirect.c is generated by a python script. The generator would have to be changed. I'd rather not do that though if it's ugly. One other comment below (for Michel): > > Roel > > backref 3: src_x > ---[ vi src/gallium/auxiliary/util/u_rect.c +30 ]--- > > void > util_copy_rect(ubyte * dst, > enum pipe_format format, > unsigned dst_stride, > unsigned dst_x, > unsigned dst_y, > unsigned width, > unsigned height, > const ubyte * src, > int src_stride, > unsigned src_x, > int src_y) It's kind of weird that src_x is unsigned but src_y is signed. Looks like Michel made the last change there (commit e922adbe1d6c1764968377658ea92ae6de0585db). Michel? > { > unsigned i; > int src_stride_pos = src_stride < 0 ? -src_stride : src_stride; > int blocksize = util_format_get_blocksize(format); > int blockwidth = util_format_get_blockwidth(format); > int blockheight = util_format_get_blockheight(format); > > assert(blocksize > 0); > assert(blockwidth > 0); > assert(blockheight > 0); > assert(src_x >= 0); > assert(src_y >= 0); > assert(dst_x >= 0); > assert(dst_y >= 0); > > backref 3: dst_y > ---[ vi src/gallium/auxiliary/util/u_rect.c +96 ]--- > void > util_fill_rect(ubyte * dst, > enum pipe_format format, > unsigned dst_stride, > unsigned dst_x, > unsigned dst_y, > unsigned width, > unsigned height, > uint32_t value) > { > unsigned i, j; > unsigned width_size; > int blocksize = util_format_get_blocksize(format); > int blockwidth = util_format_get_blockwidth(format); > int blockheight = util_format_get_blockheight(format); > > assert(blocksize > 0); > assert(blockwidth > 0); > assert(blockheight > 0); > assert(dst_x >= 0); > assert(dst_y >= 0); > > backref 3: min_lod > ---[ vi src/gallium/drivers/svga/svga_screen_texture.c +905 ]--- > struct svga_sampler_view * > svga_get_tex_sampler_view(struct pipe_context *pipe, struct pipe_texture *pt, > unsigned min_lod, unsigned max_lod) > { > struct svga_screen *ss = svga_screen(pt->screen); > struct svga_texture *tex = svga_texture(pt); > struct svga_sampler_view *sv = NULL; > SVGA3dSurfaceFormat format = svga_translate_format(pt->format); > boolean view = TRUE; > > assert(pt); > assert(min_lod >= 0); > > backref 3: num > ---[ vi src/glx/x11/indirect.c +9268 ]--- > void > __indirect_glProgramParameters4dvNV(GLenum target, GLuint index, GLuint num, > const GLdouble * params) > { > __GLXcontext *const gc = __glXGetCurrentContext(); > const GLuint cmdlen = 16 + __GLX_PAD((num * 32)); > if (num < 0) { > __glXSetError(gc, GL_INVALID_VALUE); > return; > } > if (__builtin_expect(num >= 0, 1)) { > > > backref 3: num > ---[ vi src/glx/x11/indirect.c +9292 ]--- > > #define X_GLrop_ProgramParameters4fvNV 4186 > void > __indirect_glProgramParameters4fvNV(GLenum target, GLuint index, GLuint num, > const GLfloat * params) > { > __GLXcontext *const gc = __glXGetCurrentContext(); > const GLuint cmdlen = 16 + __GLX_PAD((num * 16)); > if (num < 0) { > __glXSetError(gc, GL_INVALID_VALUE); > return; > } > if (__builtin_expect(num >= 0, 1)) { > . > ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev