On Wed, 2010-01-27 at 08:49 -0800, Brian Paul wrote: > Luca Barbieri wrote: > > Changes in v2: > > - Caps are added in a separate, subsequent patch > > > > This adds two TGSI fragment program properties that indicate the > > fragment coord conventions. > > > > The properties behave as described in the extension spec for > > GL_ARB_fragment_coord_conventions, but the default origin in > > upper left instead of lower left as in OpenGL. > > > > The syntax is: > > PROPERTY FS_COORD_ORIGIN [UPPER_LEFT|LOWER_LEFT] > > PROPERTY FS_COORD_PIXEL_CENTER [HALF_INTEGER|INTEGER] > > > > The names have been chosen for consistency with the GS properties > > and the OpenGL extension spec. > > > > The defaults are of course the previously assumed conventions: > > UPPER_LEFT and HALF_INTEGER. > > Sorry for the slow reply on this. > > It looks like you've solved the fragcoord problems in a clean/logical > way. I haven't seen any objections, so I think we can move forward > with this.
Didn't Keith had objections on this, on another thread? Luca re-sent the patch but I don't see the remark being addressed. -------- Forwarded Message -------- > From: Keith Whitwell <kei...@vmware.com> > To: Luca Barbieri <l...@luca-barbieri.com> > Cc: mesa3d-dev@lists.sourceforge.net > <mesa3d-dev@lists.sourceforge.net> > Subject: Re: [Mesa3d-dev] [PATCH 3/7] tgsi: add properties for > fragment coord conventions > Date: Tue, 26 Jan 2010 03:11:51 -0800 > > Luca, > > I would have expected fragment coord conventions to be device state, not > a part of the shader. > > It seems like these new flags are really peers (or replacements?) of the > gl_rasterization_rules flag in pipe_rasterizer_state, and that the > shaders should remain unchanged. > > Keith Jose ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
