Ditto. Better keep the empty line before PIPE_FORMAT_COUNT though.
Jose
On Fri, 2010-01-29 at 04:11 -0800, Keith Whitwell wrote:
> This looks good to me.
>
> Keith
> ________________________________________
> From: Luca Barbieri [l...@luca-barbieri.com]
> Sent: Thursday, January 28, 2010 10:35 PM
> To: mesa3d-dev@lists.sourceforge.net
> Cc: airl...@linux.ie; Luca Barbieri
> Subject: [Mesa3d-dev] [PATCH 1/2] gallium: half float vertex formats
>
> Based on work by Dave Airlie.
>
> Adds the 4 vertex formats for half float vertices.
>
> This differs from Dave Airlie's patch in that it does not add padded
> formats, but rather uses the convention already used for vertex
> formats.
>
> This allows to simplify the patches and is consistent with the
> existing code.
>
> Since vertex buffers have an explicitly specified stride, format
> padding is redundant.
>
> Future half float texture support may however need padded formats to
> be defined.
> ---
> src/gallium/include/pipe/p_format.h | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/src/gallium/include/pipe/p_format.h
> b/src/gallium/include/pipe/p_format.h
> index 6bfff1c..09b2153 100644
> --- a/src/gallium/include/pipe/p_format.h
> +++ b/src/gallium/include/pipe/p_format.h
> @@ -166,6 +166,11 @@ enum pipe_format {
> PIPE_FORMAT_DXT3_SRGBA = 108,
> PIPE_FORMAT_DXT5_SRGBA = 109,
>
> + /* half float vertex formats */
> + PIPE_FORMAT_R16_FLOAT = 110,
> + PIPE_FORMAT_R16G16_FLOAT = 111,
> + PIPE_FORMAT_R16G16B16_FLOAT = 112,
> + PIPE_FORMAT_R16G16B16A16_FLOAT = 113,
> PIPE_FORMAT_COUNT
> };
>
> --
> 1.6.6.1.476.g01ddb
>
>
> ------------------------------------------------------------------------------
> The Planet: dedicated and managed hosting, cloud storage, colocation
> Stay online with enterprise data centers and the best network in the business
> Choose flexible plans and management services without long-term contracts
> Personal 24x7 support from experience hosting pros just a phone call away.
> http://p.sf.net/sfu/theplanet-com
> _______________________________________________
> Mesa3d-dev mailing list
> Mesa3d-dev@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
>
> ------------------------------------------------------------------------------
> The Planet: dedicated and managed hosting, cloud storage, colocation
> Stay online with enterprise data centers and the best network in the business
> Choose flexible plans and management services without long-term contracts
> Personal 24x7 support from experience hosting pros just a phone call away.
> http://p.sf.net/sfu/theplanet-com
> _______________________________________________
> Mesa3d-dev mailing list
> Mesa3d-dev@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
