-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Kristian Høgsberg wrote:
It's not obvious why this is necessary. Is it to prevent multiple calls to eglCreateImage from creating multiple regions for the same bo? Some explanation in intel_region_alloc_for_handle would be helpful to people like me that aren't as familiar with some of the inner workings. :) Other than that and the trivial comment below, this looks good to me. > Signed-off-by: Kristian Høgsberg <k...@bitplanet.net> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> > --- > src/mesa/drivers/dri/intel/intel_regions.c | 24 +++++++++++++++++++++++- > src/mesa/drivers/dri/intel/intel_regions.h | 3 +++ > src/mesa/drivers/dri/intel/intel_screen.c | 14 ++++++++++++++ > src/mesa/drivers/dri/intel/intel_screen.h | 1 + > 4 files changed, 41 insertions(+), 1 deletions(-) > > diff --git a/src/mesa/drivers/dri/intel/intel_regions.c > b/src/mesa/drivers/dri/intel/intel_regions.c > index e2859e4..881653f 100644 > --- a/src/mesa/drivers/dri/intel/intel_regions.c > +++ b/src/mesa/drivers/dri/intel/intel_regions.c > @@ -42,6 +42,7 @@ > #include <sys/ioctl.h> > #include <errno.h> > > +#include <main/hash.h> You use "main/hash.h" intel_screen.c, and you should probably use the same here. > #include "intel_context.h" > #include "intel_regions.h" > #include "intel_blit.h" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkt19xUACgkQX1gOwKyEAw93qACcCi2elsVlbMnzdpXJNxCMPHil kGsAniguIshImur+LY2oQ0CY/snS3nIE =0NG8 -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
