Dnia środa, 10 marca 2010 o 19:35:48 Brian Paul napisał(a):
> Maciej Cencora wrote:
> > Dnia środa, 10 marca 2010 o 19:17:25 Maciej Cencora napisał(a):
> >> Dnia środa, 10 marca 2010 o 16:36:01 Brian Paul napisał(a):
> >>> Brian Paul wrote:
> >>>> Maciej Cencora wrote:
> >>>>> Hi,
> >>>>>
> >>>>> following 3 piglit tests are failing on r300 because they're trying
> >>>>> to use GL_ARB_texture_non_power_of_two without checking if this
> >>>>> extension is available:
> >>>>>
> >>>>> fbo-blit
> >>>>> fbo-nodepth-test
> >>>>> fbo-nostencil-test
> >>>>>
> >>>>> I'm not sure what solution is preferable, 1) change the teximage
> >>>>> sizes to be POT, 2) require ARB_texture_npot.
> >>>>> I've tried first solution for fbo-blit but it segfaults, trying to
> >>>>> execute function at null address, so it would require some more
> >>>>> investigation.
> >>>>
> >>>> We should use POT texture sizes so that the test always does
> >>>> _something_.
> >>>
> >>> I've fixed the fbo-blit test to use a POT texture. Maybe you can fix
> >>> the other tests similarly.
> >>>
> >>> BTW, I'm adding additional sub-tests to fbo-blit.c to investigate some
> >>> other bugs I've recently found...
> >>>
> >>> -Brian
> >>
> >> Sure, I'll look into it.
> >>
> >> Regards,
> >> Maciej
> >
> > It looks like you've forgotten to remove the ARB_npot check for
> > fbo-blit.
>
> Fixed.
>
> > After removing it the tests segfaults.
> > #0 0x0000000000000000 in ?? ()
> > #1 0x000000000042cfac in run_test ()
> > #2 0x000000000042d1f3 in piglit_display ()
> > #3 0x000000000042e639 in display ()
> > #4 0x00007ffff7682ddf in processWindowWorkList (window=0x673a90) at
> > glut_event.c:1306
> > #5 0x00007ffff7682ef9 in __glutProcessWindowWorkLists () at
> > glut_event.c:1356 #6 0x00007ffff7682f6f in glutMainLoop () at
> > glut_event.c:1377
> > #7 0x000000000042e7b1 in main ()
> > Unfortunately I don't know how to build the piglit tests with debugging
> > symbols to investigate it further.
>
> Run "ccmake ." and change CMAKE_BUILD_TYPE to "Debug".
>
> -Brian
>
I'm sending fixes for fbo-blit and fbo-no-depth/stencil-test tests.
Regards,
Maciej
From a1665040856c1d66dce6014e379681079a49ddf6 Mon Sep 17 00:00:00 2001
From: Maciej Cencora <m.cenc...@gmail.com>
Date: Wed, 10 Mar 2010 20:19:49 +0100
Subject: [PATCH 1/2] fbo-blit: s/glBindFramebuffer/glBindFramebufferEXT/
It doesn't segfault now on r300.
---
tests/fbo/fbo-blit.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/fbo/fbo-blit.c b/tests/fbo/fbo-blit.c
index efb5d48..0c1c289 100644
--- a/tests/fbo/fbo-blit.c
+++ b/tests/fbo/fbo-blit.c
@@ -227,8 +227,8 @@ run_test(enum copy_method method)
/* Now that we have correct samples, blit things around.
* FBO(bottom) -> WIN(middle)
*/
- glBindFramebuffer(GL_DRAW_FRAMEBUFFER_EXT, 0);
- glBindFramebuffer(GL_READ_FRAMEBUFFER_EXT, fbo);
+ glBindFramebufferEXT(GL_DRAW_FRAMEBUFFER_EXT, 0);
+ glBindFramebufferEXT(GL_READ_FRAMEBUFFER_EXT, fbo);
copy(x0, y0, x0 + SIZE, y0 + SIZE,
x0, y1, x0 + SIZE, y1 + SIZE,
method);
@@ -241,14 +241,14 @@ run_test(enum copy_method method)
method);
/* FBO(middle) -> WIN(top) back to verify WIN -> FBO */
- glBindFramebuffer(GL_DRAW_FRAMEBUFFER_EXT, 0);
- glBindFramebuffer(GL_READ_FRAMEBUFFER_EXT, fbo);
+ glBindFramebufferEXT(GL_DRAW_FRAMEBUFFER_EXT, 0);
+ glBindFramebufferEXT(GL_READ_FRAMEBUFFER_EXT, fbo);
copy(x0, y1, x0 + SIZE, y1 + SIZE,
x0, y2, x0 + SIZE, y2 + SIZE,
method);
- glBindFramebuffer(GL_DRAW_FRAMEBUFFER_EXT, 0);
- glBindFramebuffer(GL_FRAMEBUFFER_EXT, 0);
+ glBindFramebufferEXT(GL_DRAW_FRAMEBUFFER_EXT, 0);
+ glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, 0);
pass = verify_color_rect(PAD, y0, SIZE, SIZE) && pass;
pass = verify_color_rect(PAD, y1, SIZE, SIZE) && pass;
--
1.6.3.3
From c5182b3763f5e0ea02fc91d6738b361c44ff187b Mon Sep 17 00:00:00 2001
From: Maciej Cencora <m.cenc...@gmail.com>
Date: Wed, 10 Mar 2010 20:21:13 +0100
Subject: [PATCH 2/2] fbo-no(depth/stencil)test: use POT textures
---
tests/fbo/fbo-nodepth-test.c | 4 ++--
tests/fbo/fbo-nostencil-test.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/fbo/fbo-nodepth-test.c b/tests/fbo/fbo-nodepth-test.c
index eedfc3f..6ffe21f 100644
--- a/tests/fbo/fbo-nodepth-test.c
+++ b/tests/fbo/fbo-nodepth-test.c
@@ -33,8 +33,8 @@
#include "piglit-util.h"
-int piglit_width = 100;
-int piglit_height = 100;
+int piglit_width = 128;
+int piglit_height = 128;
int piglit_window_mode = GLUT_RGB | GLUT_DOUBLE;
enum piglit_result
diff --git a/tests/fbo/fbo-nostencil-test.c b/tests/fbo/fbo-nostencil-test.c
index 5615273..a548897 100644
--- a/tests/fbo/fbo-nostencil-test.c
+++ b/tests/fbo/fbo-nostencil-test.c
@@ -33,8 +33,8 @@
#include "piglit-util.h"
-int piglit_width = 100;
-int piglit_height = 100;
+int piglit_width = 128;
+int piglit_height = 128;
int piglit_window_mode = GLUT_RGB | GLUT_DOUBLE;
enum piglit_result
--
1.6.3.3
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
