----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2770/#review3219 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/2770/#comment7167> Let's change this to webui_hostname too please. src/master/http.cpp <https://reviews.apache.org/r/2770/#comment7169> s/web_ui_url/webui_hostname and swap the order please (and don't forget to propagate the changes). src/slave/slave.cpp <https://reviews.apache.org/r/2770/#comment7170> s/public_hostname/webui_hostname - Benjamin On 2011-11-08 02:46:08, Sumedh Sawant wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2770/ > ----------------------------------------------------------- > > (Updated 2011-11-08 02:46:08) > > > Review request for mesos, Benjamin Hindman and Andy Konwinski. > > > Summary > ------- > > Added webUI field to the SlaveInfo message so that a master can correctly > display hyperlinks to slaves in its webUI. > > > This addresses bug MESOS-33. > https://issues.apache.org/jira/browse/MESOS-33 > > > Diffs > ----- > > include/mesos/mesos.proto 33248ec > src/master/http.cpp 47caf48 > src/slave/slave.cpp de5716c > src/webui/master/index.tpl 16e3446 > > Diff: https://reviews.apache.org/r/2770/diff > > > Testing > ------- > > > Thanks, > > Sumedh > >
