----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2770/#review3466 -----------------------------------------------------------
Ship it! This is fantastic! Thanks! Make these changes and we'll get this committed. include/mesos/mesos.proto <https://reviews.apache.org/r/2770/#comment7726> Move this just below webui_hostname to keep the related stuff together. src/master/http.cpp <https://reviews.apache.org/r/2770/#comment7727> Let's s/web_ui_url/webui_hostname to stay consistent. Make sure the references to web_ui_url get updated too! src/slave/slave.cpp <https://reviews.apache.org/r/2770/#comment7728> Move this up above line 279. - Benjamin On 2011-11-15 02:29:18, Sumedh Sawant wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2770/ > ----------------------------------------------------------- > > (Updated 2011-11-15 02:29:18) > > > Review request for mesos, Benjamin Hindman and Andy Konwinski. > > > Summary > ------- > > Added webUI field to the SlaveInfo message so that a master can correctly > display hyperlinks to slaves in its webUI. > > > This addresses bug MESOS-33. > https://issues.apache.org/jira/browse/MESOS-33 > > > Diffs > ----- > > include/mesos/mesos.proto 33248ec > src/master/http.cpp 47caf48 > src/slave/slave.cpp de5716c > src/webui/master/index.tpl 16e3446 > > Diff: https://reviews.apache.org/r/2770/diff > > > Testing > ------- > > > Thanks, > > Sumedh > >
