[
https://issues.apache.org/jira/browse/MESOS-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154810#comment-13154810
]
[email protected] commented on MESOS-8:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2763/#review3414
-----------------------------------------------------------
src/master/constants.hpp
<https://reviews.apache.org/r/2763/#comment7643>
This should probably default to 1000 instead of 100, but I'm assuming that
Task objects are relatively small so the master could hold 100,000's (i.e. 1000
each for 100's of FWs) of them in memory without worrying too much.
Also, since its semantics are slightly different than the other constant
you added, please give it a more descriptive name like
MAX_COMPLETED_TASKS_PER_FRAMEWORK
src/master/master.cpp
<https://reviews.apache.org/r/2763/#comment7649>
I don't think you need this temporary variable here. Just do
push_back(*framework).
- Andy
On 2011-11-15 00:59:14, Thomas Marshall wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2763/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-15 00:59:14)
bq.
bq.
bq. Review request for mesos and Andy Konwinski.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Frameworks are no longer deleted when they are done executing; they are
saved in a list in the master, which is then displayed on the webui. Tasks are
similarly stored in their framework.
bq.
bq.
bq. This addresses bug MESOS-8.
bq. https://issues.apache.org/jira/browse/MESOS-8
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/webui/master/index.tpl 16e3446
bq. src/master/constants.hpp db82177
bq. src/master/http.cpp 47caf48
bq. src/master/master.hpp fdacf36
bq. src/master/master.cpp b6cfde7
bq. src/webui/master/framework.tpl 0f41349
bq.
bq. Diff: https://reviews.apache.org/r/2763/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Maintain a history of executed frameworks/tasks and show it on the web UI
> -------------------------------------------------------------------------
>
> Key: MESOS-8
> URL: https://issues.apache.org/jira/browse/MESOS-8
> Project: Mesos
> Issue Type: Improvement
> Reporter: Matei Zaharia
> Assignee: Thomas Marshall
>
> This is kind of a big task but ultimately important for cluster management.
> See https://github.com/mesos/mesos/issues#issue/39 for previous discussion on
> GitHub.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
