[
https://issues.apache.org/jira/browse/MESOS-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169861#comment-13169861
]
[email protected] commented on MESOS-8:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2990/#review3915
-----------------------------------------------------------
Ship it!
Minor nits, but clean it up and let's ship it! On to the next step!
src/slave/constants.hpp
<https://reviews.apache.org/r/2990/#comment8801>
Just put a todo at the top of the file that says: "Make these constants
configurable."
src/slave/http.cpp
<https://reviews.apache.org/r/2990/#comment8802>
Indentation?
src/slave/http.cpp
<https://reviews.apache.org/r/2990/#comment8803>
Indentation?
src/webui/slave/index.tpl
<https://reviews.apache.org/r/2990/#comment8804>
Move the % back to the beginning of the line.
src/webui/slave/index.tpl
<https://reviews.apache.org/r/2990/#comment8805>
Here too.
- Benjamin
On 2011-12-05 23:52:29, Thomas Marshall wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2990/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-05 23:52:29)
bq.
bq.
bq. Review request for mesos, Benjamin Hindman and Andy Konwinski.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added a framework history to the slave page, an executor history to the
framework page, and a task history to the executor page. Allows stdout and
stderr of executors to be viewed after they finish executing.
bq.
bq.
bq. This addresses bug MESOS-8.
bq. https://issues.apache.org/jira/browse/MESOS-8
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/slave/constants.hpp 489640b
bq. src/slave/http.cpp 18efd8c
bq. src/slave/slave.hpp 37bbd8c
bq. src/slave/slave.cpp 665ab7f
bq. src/webui/slave/executor.tpl dd53464
bq. src/webui/slave/framework.tpl 9488da5
bq. src/webui/slave/index.tpl 0f18de6
bq.
bq. Diff: https://reviews.apache.org/r/2990/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Maintain a history of executed frameworks/tasks and show it on the web UI
> -------------------------------------------------------------------------
>
> Key: MESOS-8
> URL: https://issues.apache.org/jira/browse/MESOS-8
> Project: Mesos
> Issue Type: Improvement
> Reporter: Matei Zaharia
> Assignee: Thomas Marshall
>
> This is kind of a big task but ultimately important for cluster management.
> See https://github.com/mesos/mesos/issues#issue/39 for previous discussion on
> GitHub.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
