----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3886/#review5130 -----------------------------------------------------------
Ship it! src/Makefile.am <https://reviews.apache.org/r/3886/#comment11232> Does this add it to the distribution? We really want the .sh.in versions added. - Benjamin On 2012-02-13 23:36:01, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3886/ > ----------------------------------------------------------- > > (Updated 2012-02-13 23:36:01) > > > Review request for mesos and Benjamin Hindman. > > > Summary > ------- > > This fixes several assumptions Makefile.am has about python and java bindings > being enabled and the webui being enabled: > > 1) libwebui.la is now linked to binaries only if it is actually built > 2) the examples/{java,python} files, which are generated conditionally by > configure are only required if the corresponding feature is enabled. They are > also made dependencies of mesos-tests, since it runs them. > > Also, we previously asked for the _generated_ examples/{java,python} files to > be included in the distribution, but only their corresponding .in files > should be (which should be done automatically by automake). > > > This addresses bugs MESOS-120 and MESOS-154. > https://issues.apache.org/jira/browse/MESOS-120 > https://issues.apache.org/jira/browse/MESOS-154 > > > Diffs > ----- > > src/Makefile.am f0806ab > > Diff: https://reviews.apache.org/r/3886/diff > > > Testing > ------- > > make clean && make check > > > Thanks, > > Charles > >
