> On Aug. 3, 2012, 6:58 p.m., Jie Yu wrote: > > third_party/libprocess/include/stout/net.hpp, line 77 > > <https://reviews.apache.org/r/6322/diff/2/?file=133824#file133824line77> > > > > Consider using Try<std::string> (or Result<std::string> as the return > > type? > > Ben Mahler wrote: > changed to Try as discussed with Ben :)
I don't think you updated the diff? Or at least not with the latest code. :/ - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6322/#review9834 ----------------------------------------------------------- On Aug. 4, 2012, 12:58 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6322/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2012, 12:58 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This adds a /master/redirect URL that redirects to the current leader. > > > Diffs > ----- > > src/master/http.hpp 2aeb442 > src/master/http.cpp 49ccf39 > src/master/master.hpp d02fbeb > src/master/master.cpp b0507c5 > third_party/libprocess/include/process/http.hpp a10146f > third_party/libprocess/include/stout/net.hpp 8ce0b14 > > Diff: https://reviews.apache.org/r/6322/diff/ > > > Testing > ------- > > Tested locally with 1 master. Will also test with multiple local masters. > > > Thanks, > > Ben Mahler > >
