----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6322/#review9912 -----------------------------------------------------------
src/master/http.cpp <https://reviews.apache.org/r/6322/#comment21082> Let's 'return InternalServerError(hostname.error());' third_party/libprocess/include/stout/net.hpp <https://reviews.apache.org/r/6322/#comment21083> Add a newline. third_party/libprocess/include/stout/net.hpp <https://reviews.apache.org/r/6322/#comment21084> Add an explicit '== NULL' please. third_party/libprocess/include/stout/net.hpp <https://reviews.apache.org/r/6322/#comment21085> You can just do 'return std::string(hostname)' for this one. - Benjamin Hindman On Aug. 6, 2012, 10:54 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6322/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2012, 10:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This adds a /master/redirect URL that redirects to the current leader. > > > Diffs > ----- > > src/master/http.hpp 2aeb442 > src/master/http.cpp 49ccf39 > src/master/master.hpp d02fbeb > src/master/master.cpp b0507c5 > third_party/libprocess/include/process/http.hpp a10146f > third_party/libprocess/include/stout/net.hpp 8ce0b14 > > Diff: https://reviews.apache.org/r/6322/diff/ > > > Testing > ------- > > Tested locally with 1 master. Will also test with multiple local masters. > > > Thanks, > > Ben Mahler > >
