> On Aug. 17, 2012, 5:12 p.m., Ben Mahler wrote: > > third_party/libprocess/include/process/async.hpp, line 209 > > <https://reviews.apache.org/r/6668/diff/2/?file=141936#file141936line209> > > > > ah, I see, this is the public interface people would use > > > > do/should we typically try to get the public interface at the top of > > the header?
not sure how to do it, because we are 'using' AsyncExecutor() inside async(). A forward declaration of AsyncExecutor doesn't suffice here. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6668/#review10462 ----------------------------------------------------------- On Aug. 17, 2012, 12:29 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6668/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2012, 12:29 a.m.) > > > Review request for mesos, Benjamin Hindman, John Sirois, and Jie Yu. > > > Description > ------- > > Created a new abstraction called async() (which is similar in C++11 async). > > The idea is a user could use this abstraction to delegate blocking calls (eg: > system calls). > > The implementation is a bit messy, because C++ compiler is not very smart. > But, the usage is pretty simple. > > > Diffs > ----- > > third_party/libprocess/include/process/async.hpp PRE-CREATION > third_party/libprocess/src/tests.cpp 8f4b2ae > > Diff: https://reviews.apache.org/r/6668/diff/ > > > Testing > ------- > > (inside libprocess) > > make check > > > Thanks, > > Vinod Kone > >
