> On Feb. 14, 2013, 2:13 a.m., Ben Mahler wrote: > > src/slave/cgroups_isolation_module.hpp, line 255 > > <https://reviews.apache.org/r/9408/diff/5/?file=258653#file258653line255> > > > > Can you use a more descriptive name here? > > > > e.g. > > lock > > advisoryLock > > Vinod Kone wrote: > i find it weird to name a file descriptor 'lock'. we are placing a lock > on the file. > > but i agree for the need for a more descriptive name. changed it to > lockFile. > > n.b: flock places the lock on the file not on the fd.
I see, but we still need to hold the fd right? "If a process uses open(2) (or similar) to obtain more than one descriptor for the same file, these descriptors are treated independently by flock(). An attempt to lock the file using one of these file descriptors may be denied by a lock that the calling process has already placed via another descriptor." - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9408/#review16557 ----------------------------------------------------------- On Feb. 14, 2013, 7:16 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9408/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2013, 7:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/cgroups_isolation_module.hpp > 669efa14ba2603764aa68ae19a44e79dbfdec192 > src/slave/cgroups_isolation_module.cpp > 14f549edaf1b37a6bca8f75309864333ae775e7c > src/slave/process_based_isolation_module.hpp > f1817192582e3646f8dcf17934ba7998829e8fd6 > src/slave/process_based_isolation_module.cpp > 12a579cba56cd3dac384bc7919b0d5537b0e429d > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/9408/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
