I think doing the cleanup in finalize is always the right thing to do. For e.g: we don't want cgroups lying around after the last cgroups test is run!
The fact that we do the cgroups cleanup inside initialize() in cgroups isolation module is just us being defensive against improper shutdowns. @vinodkone On Tue, Feb 19, 2013 at 4:14 PM, Benjamin Mahler <[email protected]>wrote: > Did we decide whether we want to perform finalize() cleanup? > > If so, can you comment on why we need to do it? > > > On Tue, Feb 19, 2013 at 2:56 PM, Vinod Kone <[email protected]> wrote: > >> >> ----------------------------------------------------------- >> >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/9408/ >> ----------------------------------------------------------- >> >> (Updated Feb. 19, 2013, 10:56 p.m.) >> >> >> Review request for mesos, Benjamin Hindman and Ben Mahler. >> >> >> Changes >> ------- >> >> benm's >> >> >> Description >> ------- >> >> See summary >> >> >> Diffs (updated) >> >> ----- >> >> src/slave/cgroups_isolation_module.hpp >> 669efa14ba2603764aa68ae19a44e79dbfdec192 >> src/slave/cgroups_isolation_module.cpp >> 14f549edaf1b37a6bca8f75309864333ae775e7c >> src/slave/process_based_isolation_module.hpp >> f1817192582e3646f8dcf17934ba7998829e8fd6 >> src/slave/process_based_isolation_module.cpp >> 12a579cba56cd3dac384bc7919b0d5537b0e429d >> src/tests/balloon_framework_test.sh >> 93a733f64cfde08349b7781eb3d5e13594c74498 >> >> Diff: https://reviews.apache.org/r/9408/diff/ >> >> >> Testing >> ------- >> >> make check >> >> >> Thanks, >> >> Vinod Kone >> >> >
