Hi Mayank, Thanks for the patch!
When reviewing the content of the patch it appears that there are a number of files missing which should be there. I am wondering if perhaps you accidentally did not include any of the new files you created. In particular, the patch does not compile because of missing class files and there are no tests included in it, though from your message it sounds like there should be tests present. Please check on this and resubmit an updated patch. Thanks, --Van -----Original Message----- From: [EMAIL PROTECTED] on behalf of Mayank Upadhayay Sent: Wed 10/31/2007 7:38 AM To: [email protected] Subject: [Mifos-developer] Patch Hi All, I am done with the development of loan defaults based on previous loan amount (http://www.mifos.org/developers/wiki/LoanDefaults). Also update it based on revision no-12168. I am herby sending the patch for review that includes all the development as well as test cases. During development I have made some assumptions in terms of functionality as the requirements are not very clear. Also find attached document that contains approach used, assumptions made and some open issues with their solutions. Apart from that, the inconsistency issues between client and group (issue no 1477) is there in issue tracker. Once it will be resolved I will update the code for creating an loan account for group based on product type-loan cycle. Thoughts and suggestions are welcomed. Waiting for response... Regards and Thanks, Mayank Upadhayay. Associate Developer. SunGard . Offshore Services . Divyasree Chambers Langford Road Bangalore 560025 India Tel +91-80-2222-0501 . Mobile +91-9986731792 . Fax +91-80-2222-0511 . www.sungard.com P Think before you print CONFIDENTIALITY: This email (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this email in error, please notify the sender and delete this email from your system. Thank you.
<<winmail.dat>>
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
