Hi,
I have attached the patch file to an issue; following are the link for
the same.
- https://mifos.dev.java.net/issues/show_bug.cgi?id=1613
- https://mifos.dev.java.net/issues/show_bug.cgi?id=1572
Detailed description for issue no-1572
By old accounts, I mean the accounts which were created before loan
defaults functionality comes into picture.
By new accounts, I mean the accounts which are created after the loan
defaults functionality comes into picture.
As per the specification available for loan defaults
http://www.mifos.org/developers/wiki/LoanDefaults , the min, max and
default values can be modified from edit loan product. If this is done,
it should be reflected in all the new loan accounts created after the
change has been made. It will not affect the loan accounts already
present. For this I have to persist the max, min defaults values for a
loan account at the time of creation of loan account. Doing this,
editing an account will refer to old values, even if the product max,
min, def values are changed. Max, min def, persistence functionality is
not there for the old accounts, as it was built as part of loan
defaults, because of that we are facing null pointer exception.
The patch file contains the code that resolves an issue. When the loan
account is edited, old accounts will refer to the product max, min, def
values and new accounts will refer to values which are persisted at the
time of loan account creation.
Please let me know if more information is required.
Thanks & Regards,
Mayank Upadhayay * Software Engineer * SunGard * Technology Services *
Divyasree Chambers Langford Road Bangalore 560025 India
Tel +91-80-2222-0501 * Mobile +91-9986731792 * Fax +91-80-2222-0511 *
www.sungard.com
P Think before you print
CONFIDENTIALITY: This email (including any attachments) may contain
confidential, proprietary and privileged information, and unauthorized
disclosure or use is prohibited. If you received this email in error,
please notify the sender and delete this email from your system. Thank
you.
-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Aliya Walji
Sent: Monday, February 04, 2008 10:12 PM
To: Developer
Subject: Re: [Mifos-developer] PATCH
Hi Mayank,
Thanks for the patches! If you have not already, can you attach the
patches to the respective items in the issue tracker? Also, for Issue
1572, it would be very helpful for testers (and PMs) verifying this fix
to have some more information about what the root cause of the problem
was that resulted in the Null Pointer Exceptions for the old accounts
and how you fixed this. Also, when you say 'old' accounts versus 'new'
accounts, what do you mean? What characterizes an old account - older
than a particular revision? If so, which revision? This information is
very critical to make sure that the issue can be tested thoroughly and
completely.
Thanks so much :-)
Aliya
_____ From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Mayank Upadhayay Sent: Monday, February 04, 2008 2:26 AM To: [email protected] Subject: [Mifos-developer] PATCH Hi All, I have worked on issue no- 1572 and no-1613, and get it resolved. Attached- Patch include changed code and test cases as per new functionality, for review. Below is the description of the problem and solution implemented. Issue no- 1572- Problem: - Null point exception when clicking on loan acct # from the search results page. Solution: - This problem is for the old accounts, new accounts doesn't show any null pointer exception. Patch contains the code that solves the problem. Issue no- 1613- Problem: - All the group/client loan product instances should appear. Solution: - The functionality has been changed, if a client hasn't had a loan yet, their loan should be calculated based on their "last loan amount" as being zero. Please let me know if more information is required. Suggestions are welcomed. Thanks & Regards, Mayank Upadhayay * Software Engineer * SunGard * Technology Services * Divyasree Chambers Langford Road Bangalore 560025 India Tel +91-80-2222-0501 * Mobile +91-9986731792 * Fax +91-80-2222-0511 * <http://www.sungard.com> www.sungard.com P Think before you print CONFIDENTIALITY: This email (including any attachments) may contain confidential, proprietary and privileged information, and unauthorized disclosure or use is prohibited. If you received this email in error, please notify the sender and delete this email from your system. Thank you.
1613.patch
Description: 1613.patch
1572.patch
Description: 1572.patch
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
