As I have started developing the Mifos X Android App, these two things came
to my notice that I feel should be modified.
1. The api call for authentication is called authentication, which I feel
should be authenticate as it sounds more real and closer to the naming
conventions of a RESTful service.
2. While Requesting List<Clients> the response generated is
{ "totalFilteredRecords": 2, "pageItems": [ { "id": 1, "accountNo":
"000000001", "status": { "id": 300, "code": "clientStatusType.active",
"value": "Active" }, "active": true, "activationDate": [ 2013, 3, 1 ],
"fullname": "Small shop", "displayName": "Small shop", "officeId": 1,
"officeName": "Head Office" }, { "id": 2, "accountNo": "000000002",
"status": { "id": 100, "code": "clientStatusType.pending", "value":
"Pending" }, "active": false, "fullname": "Home Farm Produce",
"displayName": "Home Farm Produce", "officeId": 1, "officeName": "Head
Office" } ] }
I feel *pageItems* should be renamed to *clients*, because this will help
in a better Mapping of the Objects. I tried to map a class using
jsonschema2pojo. But the generated result is quite ambiguous. At first
glance PageItems Class seems to come out of no where.
As I am a newbie in the field of open source, please provide your opinions
over my suggestions and let me know if my thought process with these
conventions is correct or not.
Thanks
--
You received this message because you are subscribed to the Google Groups
"Mifos Developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/mifosdeveloper.
For more options, visit https://groups.google.com/groups/opt_out.
