Markus Wiederkehr wrote:
In my opinion this issue is closely related to MIME4J-112 and MIME4J-116.
I think that in the course of MIME4J-116 we should (maybe) create
Field instances in AbstractEntity instead of later on in
MessageBuilder. A Field object could store the raw data in a byte[]
instead of a String which would greatly help with MIME4J-112.
I would very much rather prefer to not couple MIME entity classes with
Field, if possible.
The only problem is that the charset for a lenient parsing mode is not
known at this early point. But considering your clarification about
the lenient writing mode I wonder if anybody really needs a lenient
parsing mode. (I wonder if anyone really needs a lenient writing mode
for that matter.)
So maybe AbstractEntity should simply use US-ASCII to decode the
header fields without direct support for a lenient parsing mode that
nobody needs. Then AbstractEntity can build Field instances and a
ContentHandler receives those Field instances without having to parse
them again.
All in all I'm not sure if #118 should be addressed independently of
112 and 116 and whether 118 should be targeted for 0.6..
I personally dislike 'big-bang' style refactoring and prefer smaller
incremental changes when lower level components get fixed first and
remaining issues get sort of 'pushed' upwards to the higher level
components.
I'll have a patch ready by tomorrow noon. If it gets rejected, let us
revisit the idea of fixing #118, #112 and #116 all at the same time.
Cheers
Oleg
But those are just my 2 cents,
Markus
On Mon, Feb 16, 2009 at 1:27 PM, Oleg Kalnichevski (JIRA)
<[email protected]> wrote:
[
https://issues.apache.org/jira/browse/MIME4J-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oleg Kalnichevski reassigned MIME4J-118:
----------------------------------------
Assignee: oleg.kalnichevski
Working on a patch
Oleg
MIME stream parser handles non-ASCII fields incorrectly
-------------------------------------------------------
Key: MIME4J-118
URL: https://issues.apache.org/jira/browse/MIME4J-118
Project: JAMES Mime4j
Issue Type: Bug
Reporter: Oleg Kalnichevski
Assignee: oleg.kalnichevski
Fix For: 0.6
Presently MIME stream parser handles non-ASCII fields incorrectly. Binary field
content gets converted to its textual representation too early in the parsing
process using simple byte to char cast. The decision about appropriate char
encoding should be left up to individual ContentHandler implementations.
Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
