On Fri, 2009-02-20 at 13:06 +0100, Markus Wiederkehr wrote: > On Thu, Feb 19, 2009 at 6:06 PM, Oleg Kalnichevski (JIRA) > <[email protected]> wrote: > > > > [ > > https://issues.apache.org/jira/browse/MIME4J-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > > ] > > > > Oleg Kalnichevski updated MIME4J-118: > > ------------------------------------- > > > > Attachment: mime4j-118-field.patch > > > > Markus, > > > > Let's try a different approach to the problem. The new patch changes > > representation of a MIME field in the API by replacing name/value/raw tuple > > with Field interface. If you like this patch better, I'll look into > > changing the representation of raw field content from String to > > ByteArrayBuffer or similar immutable class. As a next step I would look > > into resolving MIME4J-116. > > Hi Oleg, > > sorry for the late response, I was a bit busy the last few days.. >
No problem. It is good to be busy these days. > The Field interface patch looks good to me, feel free to commit. Your > idea of providing an immutable type that can internally be cast to > something else for performance optimization sounds good as well. > > One small thing: the Javadoc of Field describes the body as "unfolded > unparsed field body string". I'm not sure if this is correct. Do you > mean the field has already been unfolded by the parser at this point? > I must confess I did not really do a good job on updating the javadocs. The above statement is certainly not correct. I'll fix it before I commit. Cheers Oleg > Markus > > > > > > Oleg > > > >> MIME stream parser handles non-ASCII fields incorrectly > >> ------------------------------------------------------- > >> > >> Key: MIME4J-118 > >> URL: https://issues.apache.org/jira/browse/MIME4J-118 > >> Project: JAMES Mime4j > >> Issue Type: Bug > >> Reporter: Oleg Kalnichevski > >> Assignee: Oleg Kalnichevski > >> Fix For: 0.6 > >> > >> Attachments: mime4j-118-field.patch, mime4j-118.patch > >> > >> > >> Presently MIME stream parser handles non-ASCII fields incorrectly. Binary > >> field content gets converted to its textual representation too early in > >> the parsing process using simple byte to char cast. The decision about > >> appropriate char encoding should be left up to individual ContentHandler > >> implementations. > >> Oleg > > > > -- > > This message is automatically generated by JIRA. > > - > > You can reply to this email to add a comment to the issue online. > > > > > > >
