[
https://issues.apache.org/jira/browse/MIME4J-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712803#action_12712803
]
Markus Wiederkehr commented on MIME4J-135:
------------------------------------------
> MimeException - use super(String, Throwable) instead of
> super(String);initCause(Throwable);.
I think the initCause code comes from a time when super(String, Throwable) was
not available. Mime4j was a Java 1.4 project until recently.
We can go for super(String, Throwable) instead of initCause() if you prefer but
IMHO it does not make much difference.
> MimeIOException - make javadoc formatting consistent with MimeException
I would like to see consistent code formatting across the library (maybe by
adding Eclipse project specific code formatter settings; useful only if all
developers used Eclipse) but I think that should have to be handled in a
separate issue.
> The rest is adding a unit test for each class.
Is that worth it? To me this looks more like testing the JRE than testing
Mime4j.. I mean all our exception classes do is invoke the super constructor
from IOException or invoke initCause(). But of course the tests don't hurt..
> [PATCH] Minor tweaks to MimeException, MimeIOException and unit tests for both
> ------------------------------------------------------------------------------
>
> Key: MIME4J-135
> URL: https://issues.apache.org/jira/browse/MIME4J-135
> Project: JAMES Mime4j
> Issue Type: Improvement
> Affects Versions: 0.6
> Reporter: Nathan Beyer
> Priority: Minor
> Fix For: 0.7
>
> Attachments: exceptions.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Attaching a patch with some minor changes to MimeException and
> MimeIOException and complete unit tests for both classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
