On 04/01/2016 12:18 PM, Jacek Caban wrote:
> On 03/31/16 18:07, Hugo Beauzée-Luyssen wrote:
>> ---
>>   mingw-w64-libraries/winstorecompat/src/GetFileAttributes.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/mingw-w64-libraries/winstorecompat/src/GetFileAttributes.c 
>> b/mingw-w64-libraries/winstorecompat/src/GetFileAttributes.c
>> index 66b2937..8d68ee0 100644
>> --- a/mingw-w64-libraries/winstorecompat/src/GetFileAttributes.c
>> +++ b/mingw-w64-libraries/winstorecompat/src/GetFileAttributes.c
>> @@ -28,8 +28,10 @@
>>    * in Windows Store applications */
>>
>>   #define GetFileAttributesW __GetFileAttributesW
>> +#define GetFileAttributesA __GetFileAttributesA
>>   #include <windef.h>
>>   #include <winbase.h>
>> +#undef GetFileAttributesA
>>   #undef GetFileAttributesW
>>
>>   DWORD WINAPI GetFileAttributesW(LPCWSTR lpFileName)
>> @@ -41,8 +43,15 @@ DWORD WINAPI GetFileAttributesW(LPCWSTR lpFileName)
>>           return INVALID_FILE_ATTRIBUTES;
>>   }
>>
>> +DWORD WINAPI GetFileAttributesA(LPCWSTR lpFileName)
>> +{
>> +    return INVALID_FILE_ATTRIBUTES;
>> +}
>
> Same as my previous, why do you need this? If we can't implement it
> properly, then fixing caller side would be preferable if possible.
>
> Jacek
>
> ------------------------------------------------------------------------------
> Transform Data into Opportunity.
> Accelerate data analysis in your applications with
> Intel Data Analytics Acceleration Library.
> Click to learn more.
> http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140
> _______________________________________________
> Mingw-w64-public mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>

I agree, that's the better solution on the paper.
However, I had quite a few symbols that I didn't manage to find the 
callsite for, so I assumed it was ok to suppress the call, just like 
it's done for GetModuleHandle.

Regards,

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to