On Sat, 13 Aug 2016, dw wrote: > I still have some more fixes for ARM, but this patch is getting too big. > This is a logical point to break.
Yes, that's probably for the best. If/when committing (iirc someone had already ok'd it?), I think it'd be even better to split it further, to one commit per issue. There also seems to be a few other changes in the patch not directly related to getting rid of warnings: - gs_support.c, only whitespace change in UNW_FLAG_NHANDLER, nothing else changed on that line? - _vswprintf_p.c, _vscwprintf_p.c - these also add a comment that wasn't there before. Probably ok, but I guess it's preferrable to have such changes split out. - aviriff.h, I see no other changes than adding in leading zeros - basetyps.h, also only fixing whitespace? - mfidl.h, changing hex constants from upper case to lower? - winnt.h, removing leading zeros in hex constants? So I think it'd be better to commit the fixes for each issue (not per file, but per issue) separately, with an explanation on what warning/issue it fixes, or why it stylistically is preferrable. (E.g. the list of files and changes you have only mention "redefine errors" for winnt.h.) // Martin ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
